Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ExoPlayer and External player while in SyncPlay #1076

Merged
merged 1 commit into from
May 22, 2023

Conversation

Maxr1998
Copy link
Member

Because neither player currently supports SyncPlay, detecting a running session and falling back to the web player makes a lot of sense.

@Maxr1998 Maxr1998 added enhancement New feature or request exoplayer Related to the ExoPlayer integration labels May 22, 2023
@Maxr1998 Maxr1998 added this to the v2.5.2 milestone May 22, 2023
@nielsvanvelzen nielsvanvelzen merged commit 49b821e into master May 22, 2023
@nielsvanvelzen nielsvanvelzen deleted the force-web-player-in-sync-play branch May 22, 2023 19:29
@swimminsparrow
Copy link

Sorry, but this change is breaking something. Many users like me have a jellyfin server setup on a raspberry with low cpu resources available. Playing in syncplay requires transcoding in many situations for the web player even on the android application. Transcoding is really laggy at the moment.

Playing it on an external player was the solution since yesterday. Maybe, the real solution for the issue is to add an option in the sync play preferences to "Disable External Player" or something like that.

@nielsvanvelzen
Copy link
Member

SyncPlay with external players doesn't work anyway. Yes it will start the external player but after that it will never sync it's state to the others in the SyncPlay room or execute the commands it receives. This is the entire reason why this change was made and we will not revert that.

@swimminsparrow
Copy link

Syncplay with external players was useful infact to "start" a video simultaneously. Now the only solution is to ask each user in the group to search the video in the library and start it manually, making something like a fingers countdown.
The real solution to the problem should be to improve the web player to avoid transcoding on each video, but obviously this is not in the roadmap.
I really think a workaround could be an option in the syncplay preferences. I don't think many users use the web player. The only reason to have jellyfin for android installed was the syncplay working even in this "bad" way and so was preferrable to a native solution as findroid is.
This is only an opinion. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exoplayer Related to the ExoPlayer integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants