Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BackPressInterceptor #1172

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

timm0e
Copy link
Contributor

@timm0e timm0e commented Aug 24, 2023

This removes usages of the deprecated onBackPress method and instead relies on the new onBackPressedDispatcher while providing compatibility with the way we stack Fragments on top of each other (see BackPressInterceptor.kt for a more detailed explanation).

@jellyfin-bot jellyfin-bot added this to the v2.6.0 milestone Aug 24, 2023
Maxr1998
Maxr1998 previously approved these changes Aug 24, 2023
@Maxr1998 Maxr1998 added the enhancement New feature or request label Aug 24, 2023
This removes usages of the deprecated onBackPress method and instead relies on the new onBackPressedDispatcher while providing compatibility with the way we stack Fragments on top of each other (see BackPressInterceptor.kt for a more detailed explanation).
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Those oddities with the OnBackPressDispatcher API are surely interesting. Thanks for documenting your changes with so much detail!

@Maxr1998 Maxr1998 merged commit 858ce16 into jellyfin:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants