Ensure ExternalPlayer always direct plays #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove now unnecessary device profile, and set high bitrate limit so that we never exceed it.
Maxr1998
added
bug
Maxr1998
force-pushed
the
external-player-fixes
branch
from
f0705a4 to
4a6a23e
Compare
nielsvanvelzen
requested changes
Sep 2, 2023
Maxr1998
force-pushed
the
external-player-fixes
branch
from
4a6a23e to
7b0bd3d
Compare
nielsvanvelzen
approved these changes
Sep 3, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a device profile like for ExoPlayer, we always build the direct stream URL, and at the same time tweak the media source request so that it never suggests transcoding. We do that by supplying an effectively unlimited maximum bit rate, which was previously hard-coded to 120 Mbps through the device profile.
Fixes #970.