Merge pull request #824 from nielsvanvelzen/822-save-displaypreferences

Fix DisplayPreferencesScreen not saving the preferences
jellyfin · Apr 26, 2021 · d4fe7b5 · d4fe7b5
2 parents e2cc67a + da21fb8
commit d4fe7b5
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/app/src/main/java/org/jellyfin/androidtv/ui/browsing/DisplayPreferencesScreen.kt b/app/src/main/java/org/jellyfin/androidtv/ui/browsing/DisplayPreferencesScreen.kt
@@ -2,13 +2,28 @@ package org.jellyfin.androidtv.ui.browsing
 
 import org.jellyfin.androidtv.R
 import org.jellyfin.androidtv.TvApp
-import org.jellyfin.androidtv.ui.preference.dsl.*
+import org.jellyfin.androidtv.ui.preference.dsl.OptionsFragment
+import org.jellyfin.androidtv.ui.preference.dsl.checkbox
+import org.jellyfin.androidtv.ui.preference.dsl.lazyOptionsScreen
+import org.jellyfin.androidtv.ui.preference.dsl.list
+import timber.log.Timber
 
 class DisplayPreferencesScreen : OptionsFragment() {
+ private val preferencesId by lazy {
+ requireArguments().getString(ARG_PREFERENCES_ID)
+ }
+
  // Requires the caller of this view to pre-cache the display preferences
  private val displayPreferences by lazy {
- val id = requireArguments().getString(ARG_PREFERENCES_ID)
- TvApp.getApplication().getCachedDisplayPrefs(id)
+ Timber.d("Loading cached display preferences with id $preferencesId")
+ TvApp.getApplication().getCachedDisplayPrefs(preferencesId)
+ }
+
+ override fun onStop() {
+ super.onStop()
+
+ Timber.d("Saving cached display preferences with id $preferencesId")
+ TvApp.getApplication().updateDisplayPrefs(displayPreferences)
  }
 
  override val screen by lazyOptionsScreen {