Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed playFrom() crash, support queueing entire row (eg: last played) #1568

Merged
merged 2 commits into from
Mar 27, 2022

Conversation

mueslimak3r
Copy link
Member

@mueslimak3r mueslimak3r commented Mar 26, 2022

Changes

  • fixed crash when calling playFrom() where the player was unintentionally released
  • clicking on an audio item will now:
  • open NowPlayingActivity if it is the currently playing item
  • use playFrom() to skip within the queue (and not affect things like shufffle, etc) if the item belongs to the queue
  • otherwise, start a new session by adding the items in the row to the queue and playing from the selected item's index. This means we can easily play all "last played" songs
  • playNow() will loop through its input list and create a new list of only audio items. This protects against accidentally adding video items if an entire row is added to the queue. I don't know of any rows that have mixed A/V items but better safe than sorry, and the methods for adding to the video queue already do this.

  • changed deprecated mExoPlayer.stop(boolean) -> mExoPlayer.stop()

Issues

  • the audio player was being released unintentionally
  • playFrom() in the context menu was missing a return statement, which caused some weird behavior

@mueslimak3r mueslimak3r marked this pull request as ready for review March 27, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants