Fix srt newline parsing, revert subtitle alignment back to left align #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<br>. Subtitles that use line-feed only (\n) can now be parsed in addition to CRLF (\r+\n), which was previously the only format parsed.gravity="center"for the subtitle TextViewIssues
.srtsubtitles as an example, some use the "line-feed only" format, which wasn't handled. Because of this, subtitles which should be displayed as multiple lines could display as only one.Notes
AlignmentSpanto get thePaddedBackgroundSpanto draw its background around the centered text. Unfortunately, this didn't work. Working with spans is a pain, and it seems like a solution that allows for centered text and functional backgrounds might require a custom span.