Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live tv guide option button styles #1864

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

thornbill
Copy link
Member

Changes
Fixes some styling issues with the filter/setting buttons on the live tv guide

  • Fixes highlight tint of icon by using the Button.Icon style
  • Increases the right margin to align with the clock and prevent buttons being in the overscan area
  • Reduces the padding of the filter button so it is more consistent with the size of the other button icons

Issues
N/A

@thornbill thornbill added the enhancement New feature or request label Jul 19, 2022
android:layout_width="25dp"
android:layout_height="25dp"
android:id="@+id/optionsButton"
android:layout_marginRight="10sp"
android:layout_marginRight="40sp"

Check warning

Code scanning / Android Lint

Using left/right instead of start/end attributes

Consider replacing android:layout_marginRight with android:layout_marginEnd="40sp" to better support right-to-left layouts
@nielsvanvelzen nielsvanvelzen merged commit 94c41ed into jellyfin:master Jul 20, 2022
@thornbill thornbill deleted the fix-guide-button-styles branch July 20, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants