fix NextUp not working without clearing old video queue items #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
the
refactor
nielsvanvelzen
approved these changes
Aug 10, 2022
| @@ -986,7 +986,9 @@ public void resumeAudio() { | |||
| } | |||
|
|
|||
| public void setCurrentMediaPosition(int currentMediaPosition) { | |||
| this.mCurrentMediaPosition = currentMediaPosition; | |||
| if (!hasVideoQueueItems() || currentMediaPosition < 0 || currentMediaPosition > getCurrentVideoQueue().size()) | |||
There was a problem hiding this comment.
This breaks the old and new photo viewers (app crashes when trying to view a photo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
playbackControllerandmediaManagerset the video queue index in
mediaManagerviaplaybackControllerinnext(),prev(), anditemCompleted()removePreviousQueueItems()it was used to clear already-played items from
playbackControllerbefore opening NextUp because there previously wasn't support for starting playback from a specific video queue index (added in Fix 'Play from Here' in video playlists #1939)itemComplete()Issues
previousbutton will break if the previous video queue items have been removed byremovePreviousQueueItems()😂Notes
playbackControllerandvideoManagerand then syncing them is kinda lame. 😔