Refactor BrowseGridFragment hierarchy into a single class #1970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrowseGridFragment was the only one using these two
Before:
BrowseGridFragment extends StdGridFragment extends GridFragment extends Fragment
After:
BrowseGridFragment Fragment
Merging these classes removed a lot of boilerplate code and should make it easier to maintain it. Although the code is still quite messy. I've removed all the getter/setter functions that were only used in the class itself and merged some variables that were kept in both the grid and browsegrid fragments.
There are no behavior changes in this PR.
Changes
Issues