Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SDK in HomeFragment #2013

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Use SDK in HomeFragment #2013

merged 1 commit into from
Aug 27, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Use SDK in HomeFragment
    • This only applies for API usage directly in the home code - not in the rows
  • Remove unused apiclient extensions callApi and callApiEmpty

Issues

@nielsvanvelzen nielsvanvelzen added sdk-migration To fix this we need to migrate some code to the new SDK refactor Improvements to code realiability, readability and quality labels Aug 27, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Aug 27, 2022
@nielsvanvelzen nielsvanvelzen merged commit 80d34e5 into jellyfin:master Aug 27, 2022
@nielsvanvelzen nielsvanvelzen deleted the sdk-home branch August 27, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality sdk-migration To fix this we need to migrate some code to the new SDK
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero