Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app crashing when opening "other options" menu in FullDetailsActivity #2029

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Fix app crashing when opening "other options" menu in FullDetailsActivity #2029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions app/src/main/java/org/jellyfin/androidtv/ui/itemdetail/FullDetailsActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,6 @@ private void gotoSeries() {
private TextUnderButton shuffleButton = null;
private TextUnderButton goToSeriesButton = null;
private TextUnderButton queueButton = null;
private TextUnderButton deleteButton = null;
private TextUnderButton moreButton;
private TextUnderButton playButton = null;
private TextUnderButton trailerButton = null;
Expand Down Expand Up @@ -1323,12 +1322,6 @@ public void onClick(View v) {
more.getMenu().getItem(5).setVisible(true);
}

if (deleteButton == null || ViewKt.isVisible(deleteButton)) {
more.getMenu().getItem(6).setVisible(false);
} else if (deleteButton != null) {
more.getMenu().getItem(6).setVisible(true);
}

more.show();
}
});
Expand Down Expand Up @@ -1377,7 +1370,6 @@ private void showMoreButtonIfNeeded() {
if (trailerButton != null) actionsList.add(trailerButton);
if (favButton != null) actionsList.add(favButton);
if (goToSeriesButton != null) actionsList.add(goToSeriesButton);
if (deleteButton != null) actionsList.add(deleteButton);

// reverse the list so the less important actions are hidden first
Collections.reverse(actionsList);
Expand Down