Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random device id when initializing QuickConnect #2038

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

nielsvanvelzen
Copy link
Member

Temporary fix until @crobibero creates a new authentication controller (let's call it v2) from scratch, with proper JWT access tokens, refresh tokens and device info included in that access token instead of the stupid header stuff.

Changes

  • Use random device id when initializing QuickConnect
  • This fixes the issue where existing sessions get destroyed by the server

Issues

@nielsvanvelzen nielsvanvelzen added bug Something isn't working backportable Change may be backported to a point release (remove label once cherrypicked) labels Sep 6, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Sep 6, 2022
@nielsvanvelzen nielsvanvelzen linked an issue Sep 6, 2022 that may be closed by this pull request
Copy link
Member

@crobibero crobibero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

@nielsvanvelzen nielsvanvelzen merged commit 02b9fb6 into jellyfin:master Sep 6, 2022
@nielsvanvelzen nielsvanvelzen deleted the qc-random-id branch September 6, 2022 16:19
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.15.0, v0.14.3 Sep 6, 2022
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember multiple users credentials without having to sign in
2 participants