Rewrite DeviceUtils and Utils in Kotlin #2056
Conversation
nielsvanvelzen
added
the
refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * A collection of utility methods, all static. | ||
| */ | ||
| object Utils { |
Check warning
Code scanning / detekt
Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together.
|
|
||
| return when { | ||
| maxRate == UserPreferences.MAX_BITRATE_AUTO && autoRate != null -> autoRate.toInt() | ||
| else -> (maxRate.toFloat() * 1000000).toInt() |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
|
|
||
| @JvmStatic | ||
| fun getSafeSeekPosition(position: Long, duration: Long): Long = when { | ||
| position >= duration -> (duration - 1000).coerceAtLeast(0) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
| private const val FIRE_STICK_4K_MAX_MODEL = "AFTKA" | ||
|
|
||
| // Fire TV Cube Models | ||
| private const val FIRE_CUBE_MODEL_GEN_1 = "AFTA" |
Check warning
Code scanning / detekt
Private member is unused and should be removed.
|
|
||
| // Fire TV Cube Models | ||
| private const val FIRE_CUBE_MODEL_GEN_1 = "AFTA" | ||
| private const val FIRE_CUBE_MODEL_GEN_2 = "AFTR" |
Check warning
Code scanning / detekt
Private member is unused and should be removed.
| // Fire TV (Box) Models | ||
| private const val FIRE_TV_MODEL_GEN_1 = "AFTB" | ||
| private const val FIRE_TV_MODEL_GEN_2 = "AFTS" | ||
| private const val FIRE_TV_MODEL_GEN_3 = "AFTN" |
Check warning
Code scanning / detekt
Private member is unused and should be removed.
Changes
Issues