Add Video Codec Tag #2245
Merged
Add Video Codec Tag #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private static void addVideoCodecDetails(Context context, LinearLayout layout, MediaStream stream) { | ||
| if (stream != null) { | ||
| if (stream.getCodec() != null && stream.getCodec().trim().length() > 0) { | ||
| String codec = stream.getCodec().toUpperCase(); |
Check warning
Code scanning / Android Lint
Implied default locale in case conversion
nielsvanvelzen
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Video Codec Tag to Item View Page
Changes
Adds an additional tag to Created
addVideoCodecDetailsfunction to InfoLayoutHelper.java. The function is called byaddRatingAndResin the same file to add a tag with the codec name after the resolution tag.Issues
Fixes #2244