Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in ExternalPlayerActivity when getMediaSource() returns null #2272

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix NPE in ExternalPlayerActivity when getMediaSource() returns null #2272

merged 1 commit into from
Nov 17, 2022

Conversation

nielsvanvelzen
Copy link
Member

Untested but should fix the NPE from the logs in the issue.

Changes

  • Check null value in StreamInfo.getSubtitleProfiles

Issues

Fixes #2269

@nielsvanvelzen nielsvanvelzen added the crash Bug causing app crashes label Nov 16, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Nov 16, 2022
@nielsvanvelzen nielsvanvelzen merged commit aeebbaf into jellyfin:master Nov 17, 2022
@nielsvanvelzen nielsvanvelzen deleted the external-npe branch November 17, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
crash Bug causing app crashes
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

Crush when 'Pass Direct Path for external player' is enabled and starting a video with VLC
2 participants
@nielsvanvelzen @crobibero