Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remember button focus on summary page" #2336

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Revert "Remember button focus on summary page" #2336

merged 1 commit into from
Dec 10, 2022

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Dec 10, 2022 •
edited
Loading

Reverts #2297

There are two issues with the PR:

  1. The global listener isn't removed when the view detaches, this is an easy fix. just store it in a var and add/remove in onAttachedToWindow/onDetachedFromWindow
  2. The call requestFocus() somehow crashes the app when viewing a person opened via a movie. I have no clue why and I tried to fix it for about 3 hours after giving up. This is the reason for the revert.

Fixes #2331

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Dec 10, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Dec 10, 2022
@nielsvanvelzen
Copy link
Member Author

Hey @teobaranga unfortunately I'll need to revert your PR due to the mentioned issue. I'm trying to stabilize 0.15 for release and I was unable to fix it myself. If you're able to fix it you can recreate the original PR with the fix and we'll merge it.

teobaranga
teobaranga approved these changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@teobaranga teobaranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍 I'm looking into this and will open a new PR once I have a proper fix, sorry about that

@nielsvanvelzen nielsvanvelzen merged commit f017866 into master Dec 10, 2022
@nielsvanvelzen nielsvanvelzen deleted the revert-2297-remember_button_focus branch December 10, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teobaranga teobaranga teobaranga approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

Crash when navigating person bio in movies
3 participants
@nielsvanvelzen @teobaranga @crobibero