Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct path option from external player #2342

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

nielsvanvelzen
Copy link
Member

Direct paths have been deprecated in the server a while back (and is pending removal). Now that it broke in 0.15 it's easier to remove then to fix it.

Changes

  • Remove direct path option from external player
  • Remove unused constants from ExternalPlayerActivity
  • Format ExternalPlayerActivity

Issues

Fixes #2269

Direct paths have been deprecated in the server a while back (and is pending removal). Now that it broke in 0.15 it's easier to remove then to fix it.
@nielsvanvelzen nielsvanvelzen added bug Something isn't working crash Bug causing app crashes labels Dec 13, 2022
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Dec 13, 2022
@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review December 13, 2022 20:28
…layerActivity.java

Co-authored-by: Cody Robibero <cody@robibe.ro>
@nielsvanvelzen nielsvanvelzen merged commit aca0c45 into jellyfin:master Dec 14, 2022
@nielsvanvelzen nielsvanvelzen deleted the drop-direct-path branch December 14, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash Bug causing app crashes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crush when 'Pass Direct Path for external player' is enabled and starting a video with VLC
2 participants