Allow all supported audio codecs in ExoPlayer transcoding profile #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 I wonder if this is the cause of all the reports of unnecessary audio transcoding... |
|
I can confirm it fixes that issue. Previously the dashboard said the transcode reason was because of audio, now it says it's because of the subtitles. So far everything seems to work fine for me. But I'm still not sure if it fits for 0.15.1 or if we should put it back to 0.16.0. |
|
After tinkering about it for a bit I think we should include this in 0.15.z. I don't expect new issues from this change and we can always revert if a bug appears. |
|
https://exoplayer.dev/supported-formats.html |
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only tested this one a single video item that needed transcoding for subs but also transcoded the audio. Not sure why the transcoding profile didn't allow all audio codecs.
Changes
Issues