Prevent usage of Jellyfin 10.9 to prevent crashes due to incompatibility #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -465,6 +465,7 @@ | |||
| <string name="live_tv_preferences">Live TV options</string> | |||
| <string name="app_notification_uimode_invalid">This app is optimized for televisions. We recommend using our mobile app on other devices.</string> | |||
| <string name="server_unsupported_notification">This server uses Jellyfin version %1$s which is unsupported. Please update to Jellyfin %2$s or newer to continue using the app.</string> | |||
| <string name="server_unsupported_notification_downgrade">This server uses Jellyfin version %1$s which is unsupported. Please downgrade to Jellyfin %2$s to continue using the app.</string> | |||
Check warning
Code scanning / Android Lint
Unused resources Warning
| val versionSupported = serverVersion != null && serverVersion >= ServerRepository.minimumServerVersion | ||
|
|
||
| val versionTooOld = serverVersion == null || serverVersion < ServerRepository.minimumServerVersion | ||
| val versionTooNew = serverVersion != null && ServerRepository.minimumUnsupportedServerVersion != null && serverVersion >= ServerRepository.minimumUnsupportedServerVersion |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
| @@ -63,7 +63,7 @@ | |||
| userLoginViewModel.loginState.onEach { state -> | |||
| when (state) { | |||
| is ServerVersionNotSupported -> binding.error.setText(getString( | |||
| R.string.server_issue_outdated_version, | |||
| if (state.server.versionTooNew) R.string.server_issue_unsupported_version else R.string.server_issue_outdated_version, | |||
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
| @@ -70,7 +70,7 @@ | |||
| userLoginViewModel.loginState.onEach { state -> | |||
| when (state) { | |||
| is ServerVersionNotSupported -> binding.error.setText(getString( | |||
| R.string.server_issue_outdated_version, | |||
| if (state.server.versionTooNew) R.string.server_issue_unsupported_version else R.string.server_issue_outdated_version, | |||
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
|
Closing as I don't see much use for this anymore. It would also require us to keep bumping the unsupported version periodically so it doesn't create false-positives and I'm sure I'm going to forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a minimum supported server version, this PR adds a minimum unsupported version (the first version we know doesn't work). Right now the app and 10.9 are incompatible. Depending on how many issue reports are going to come in I'll decide if we really need this or not (in which case the PR will suddenly be gone)
Changes
Issues