Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from java.util.Date to java.time #3550

Merged
merged 6 commits into from
May 4, 2024
Merged

Migrate from java.util.Date to java.time #3550

merged 6 commits into from
May 4, 2024

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Migrate a bunch of code to java.time

Issues

@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label May 4, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone May 4, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems May 4, 2024
View reviewed changes
app/src/main/java/org/jellyfin/androidtv/util/TimeUtils.java
@@ -151,4 +126,9 @@

return Date.from(date.atZone(zone).toInstant());
}
public static LocalDateTime getLocalDateTime(Date date) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
app/src/main/java/org/jellyfin/androidtv/util/TimeUtils.java
@@ -151,4 +126,9 @@

return Date.from(date.atZone(zone).toInstant());
}
public static LocalDateTime getLocalDateTime(Date date) {

Check notice

Code scanning / Android Lint

Unknown nullness Note

Unknown nullability; explicitly declare as @Nullable or @NonNull to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations
@nielsvanvelzen nielsvanvelzen merged commit e596cf8 into jellyfin:master May 4, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the java-time branch May 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero