Initial video support in playback rewrite #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -53,17 +60,30 @@ | |||
| ).show() | |||
| Timber.i(item.toString()) | |||
|
|
|||
| // TODO: Create queue, send to new playback manager, start new player UI | |||
| finishAfterTransition() | |||
| // TODO: Dirty hack to create a single item queue | |||
Check warning
Code scanning / detekt
Flags a forbidden comment. Warning
| } | ||
| } | ||
|
|
||
| // TODO: Dirty hack to display surface |
Check warning
Code scanning / detekt
Flags a forbidden comment. Warning
crobibero
approved these changes
May 7, 2024
|
#2455 👀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the initial changes to get video playback working. Currently only direct-play is actually functional and you need to make sure your media can play yourself as codec detection is not working.
When media does play it already integrates with remote control and media sessions. Playback progress is also properly tracked. There are also funny bugs, like the screensaver showing the video your playing because we don't filter for music only.
Also, no subtitles at all right now.
Changes
Issues
Part of #1057