Use dependency injection for ItemLauncher, KeyProcessor and ReportingHelper #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
the
refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (liveTvPreferences.get(LiveTvPreferences.Companion.getShowRepeatIndicator()) && Utils.isTrue(program.getIsRepeat())) { | ||
| InfoLayoutHelper.addBlockText(context, mInfoRow, context.getString(R.string.lbl_repeat), 10, Color.GRAY, androidx.leanback.R.color.lb_default_brand_color); | ||
| addBlockText(context.getString(R.string.lbl_repeat), 10, Color.GRAY, androidx.leanback.R.color.lb_default_brand_color); |
Check warning
Code scanning / Android Lint
Using private resources Warning
| TextView view = new TextView(getContext()); | ||
| view.setTextSize(size); | ||
| view.setTextColor(textColor); | ||
| view.setText(" " + text + " "); |
Check warning
Code scanning / Android Lint
TextView Internationalization Warning
| } | ||
|
|
||
| public static Destination.Fragment getUserViewDestination(@Nullable final BaseItemDto baseItem) { | ||
| public Destination.Fragment getUserViewDestination(@Nullable final BaseItemDto baseItem) { |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| public static void launch(final BaseRowItem rowItem, ItemRowAdapter adapter, int pos, final Context context) { | ||
| NavigationRepository navigationRepository = KoinJavaComponent.<NavigationRepository>get(NavigationRepository.class); | ||
|
|
||
| public void launch(final BaseRowItem rowItem, ItemRowAdapter adapter, int pos, final Context context) { |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| public static void launch(final BaseRowItem rowItem, ItemRowAdapter adapter, int pos, final Context context) { | ||
| NavigationRepository navigationRepository = KoinJavaComponent.<NavigationRepository>get(NavigationRepository.class); | ||
|
|
||
| public void launch(final BaseRowItem rowItem, ItemRowAdapter adapter, int pos, final Context context) { |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| private final Lazy<DataRefreshService> dataRefreshService = KoinJavaComponent.<DataRefreshService>inject(DataRefreshService.class); | ||
| private final Lazy<ApiClient> apiClient = KoinJavaComponent.<ApiClient>inject(ApiClient.class); | ||
|
|
||
| public void reportStopped(org.jellyfin.sdk.model.api.BaseItemDto item, StreamInfo streamInfo, long pos) { |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public static void reportStart(org.jellyfin.sdk.model.api.BaseItemDto item, long pos) { | ||
| public void reportStart(org.jellyfin.sdk.model.api.BaseItemDto item, long pos) { |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| Timber.i("Playback of %s started.", item.getName()); | ||
| } | ||
|
|
||
| public static void reportProgress(@Nullable PlaybackController playbackController, org.jellyfin.sdk.model.api.BaseItemDto item, StreamInfo currentStreamInfo, Long position, boolean isPaused) { | ||
| public void reportProgress(@Nullable PlaybackController playbackController, org.jellyfin.sdk.model.api.BaseItemDto item, StreamInfo currentStreamInfo, Long position, boolean isPaused) { |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| Timber.i("Playback of %s started.", item.getName()); | ||
| } | ||
|
|
||
| public static void reportProgress(@Nullable PlaybackController playbackController, org.jellyfin.sdk.model.api.BaseItemDto item, StreamInfo currentStreamInfo, Long position, boolean isPaused) { | ||
| public void reportProgress(@Nullable PlaybackController playbackController, org.jellyfin.sdk.model.api.BaseItemDto item, StreamInfo currentStreamInfo, Long position, boolean isPaused) { |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| Timber.i("Playback of %s started.", item.getName()); | ||
| } | ||
|
|
||
| public static void reportProgress(@Nullable PlaybackController playbackController, org.jellyfin.sdk.model.api.BaseItemDto item, StreamInfo currentStreamInfo, Long position, boolean isPaused) { | ||
| public void reportProgress(@Nullable PlaybackController playbackController, org.jellyfin.sdk.model.api.BaseItemDto item, StreamInfo currentStreamInfo, Long position, boolean isPaused) { |
Check notice
Code scanning / Android Lint
Unknown nullness Note
crobibero
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to add replay gain support to playback rewrite but need to convert all item calls to use the SDK first so we can actually read the value from BaseItemDto. sad
Changes
Issues