Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FakeBaseItem hack #3581

Merged
merged 5 commits into from
May 16, 2024
Merged

Conversation

nielsvanvelzen
Copy link
Member

The primary goal here was to remove the FakeBaseItem hack. Bunch of related sacrifices had to be made to complete this pentagram though.

Changes

  • Split MusicFavoritesListFragment from ItemListFragment
    • Basically a glorified duplicate fragment class with obsolete code removed
  • Add an extra to BrowseViewFragment to indicate it should show series timers instead of a fake base item
    • And some related changes in places that would crash if item is null
  • Fix context menu showing for last selected base item when opening on gridbutton (e.g. music favorites button)
  • Remove FakeBaseItem
  • Dropped tears from eyes

Issues

@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label May 16, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone May 16, 2024
@nielsvanvelzen nielsvanvelzen merged commit dc8f97c into jellyfin:master May 16, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the no-fake-items branch May 18, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants