Refactor FullDetailsFragment to use SDK #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
sdk-migration
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
|
|
||
| play(episodes.items, 0, false) | ||
| } catch (err: ApiClientException) { |
Check warning
Code scanning / detekt
The caught exception is swallowed. The original exception could be lost. Warning
| @@ -1466,12 +1351,13 @@ | |||
| } | |||
|
|
|||
| RecordPopup mRecordPopup; | |||
| public void showRecordingOptions(String id, final org.jellyfin.sdk.model.api.BaseItemDto program, final boolean recordSeries) { | |||
|
|
|||
| public void showRecordingOptions(String id, final BaseItemDto program, final boolean recordSeries) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -1466,12 +1351,13 @@ | |||
| } | |||
|
|
|||
| RecordPopup mRecordPopup; | |||
| public void showRecordingOptions(String id, final org.jellyfin.sdk.model.api.BaseItemDto program, final boolean recordSeries) { | |||
|
|
|||
| public void showRecordingOptions(String id, final BaseItemDto program, final boolean recordSeries) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
|
|
||
| private DisplayMetrics mMetrics; | ||
|
|
||
| protected org.jellyfin.sdk.model.api.BaseItemDto mProgramInfo; | ||
| protected BaseItemDto mProgramInfo; |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| protected SeriesTimerInfoDto mSeriesTimerInfo; | ||
| protected UUID mItemId; | ||
| protected UUID mChannelId; | ||
| protected BaseRowItem mCurrentItem; | ||
| private Instant mLastUpdated; | ||
| private UUID mPrevItemId; | ||
| public UUID mPrevItemId; |
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -257,11 +257,11 @@ | |||
| staticHeight = true; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, BaseItemPerson[] people, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
| public ItemRowAdapter(List<BaseItemPerson> people, Context context, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -257,11 +257,11 @@ | |||
| staticHeight = true; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, BaseItemPerson[] people, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
| public ItemRowAdapter(List<BaseItemPerson> people, Context context, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -257,11 +257,11 @@ | |||
| staticHeight = true; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, BaseItemPerson[] people, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
| public ItemRowAdapter(List<BaseItemPerson> people, Context context, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
| @@ -257,11 +257,11 @@ | |||
| staticHeight = true; | |||
| } | |||
|
|
|||
| public ItemRowAdapter(Context context, BaseItemPerson[] people, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
| public ItemRowAdapter(List<BaseItemPerson> people, Context context, Presenter presenter, MutableObjectAdapter<Row> parent) { | |||
Check notice
Code scanning / Android Lint
Unknown nullness Note
crobibero
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the FullDetailsFragment to use the SDK for all non-livetv code. There's still 15 direct API calls left for Live TV. Will tackle those at some point in the future.
Some behavior changes had to be made because of some Live TV hacks (SeriesTimers is not a valid BaseItem type). Also some (small) cleaning done. Overall this file is a PITA to deal with as it tries to literally support all the item types we have.
Issues