Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BaseRowItem to use inheritance #3598

Merged
merged 15 commits into from
May 25, 2024
Merged

Refactor BaseRowItem to use inheritance #3598

merged 15 commits into from
May 25, 2024

Commits on May 22, 2024

  1. Only use SDK types in BaseRowItem 

    This also cleans the constructor hell a bit (although still a mess)
    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3ba0696 View commit details
    Browse the repository at this point in the history

  2. Refactor BaseRowItem constructors into subclasses

    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    e5d396c View commit details
    Browse the repository at this point in the history

  3. Move function implementations to BaseRowItem subclasses

    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0de85b2 View commit details
    Browse the repository at this point in the history

  4. Move properties to BaseRowItem subclasses

    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    755f0f6 View commit details
    Browse the repository at this point in the history

  5. Add missing BaseItemKinds in BaseItemDtoBaseRowItem

    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1074756 View commit details
    Browse the repository at this point in the history

  6. Remove refresh function from BaseRowItem

    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ef07ebd View commit details
    Browse the repository at this point in the history

  7. Optimize MutableObjectAdapter.remove(element: T)

    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1bad4c0 View commit details
    Browse the repository at this point in the history

  8. Make BaseRowItem immutable

    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    38e826d View commit details
    Browse the repository at this point in the history

  9. Remove dependency injection from BaseRowItem

    @nielsvanvelzen
    nielsvanvelzen committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8d04ff3 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Use properties when possible in BaseRowItem

    @nielsvanvelzen
    nielsvanvelzen committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1ea34ac View commit details
    Browse the repository at this point in the history

  2. Remove index property from BaseRowItem

    @nielsvanvelzen
    nielsvanvelzen committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6d5b22c View commit details
    Browse the repository at this point in the history

  3. Move even more BaseRowItem properties

    @nielsvanvelzen
    nielsvanvelzen committed May 23, 2024
    Configuration menu
    Copy the full SHA
    74446e1 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Remove index from AudioQueueBaseRowItem

    @nielsvanvelzen
    nielsvanvelzen committed May 25, 2024
    Configuration menu
    Copy the full SHA
    a8a8d39 View commit details
    Browse the repository at this point in the history

  2. Fix ItemRowAdapter counts after index removal

    @nielsvanvelzen
    nielsvanvelzen committed May 25, 2024
    Configuration menu
    Copy the full SHA
    a5e538b View commit details
    Browse the repository at this point in the history

  3. Remove unused ChangeTriggerTypes

    @nielsvanvelzen
    nielsvanvelzen committed May 25, 2024
    Configuration menu
    Copy the full SHA
    6e4c27b View commit details
    Browse the repository at this point in the history