Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login with pruned sessions #3632

Merged

Conversation

nielsvanvelzen
Copy link
Member

Few login related issues found while trying to fix one of them. In short, when you remove a session from the Jellyfin dashboard the app can no longer sign into that account due to race conditions, magic and more.

Changes

  • Fix UserLoginFragment not using lifecycle correctly
  • Fix AuthenticationRepository leaking access token to logs
  • Fix SessionRepository applying crash reporting information before validating token
  • Fix StartupActivity preventing invalid login from opening login fragment
  • Remove redundant if statement in UserRepository
  • Use ApiClient.update in UserLoginViewModel (not backportable)

Issues

@nielsvanvelzen nielsvanvelzen added bug Something isn't working authentication Issue related to authentication backportable Change may be backported to a point release (remove label once cherrypicked) labels Jun 1, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jun 1, 2024
@nielsvanvelzen nielsvanvelzen merged commit d9eb4fb into jellyfin:master Jun 1, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the login-invalidation-fix branch June 1, 2024 12:49
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Issue related to authentication bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants