Replace ItemQuery with GetItemsRequest #3654
Conversation
nielsvanvelzen
added
sdk-migration
|
With this the only places left using the legacy ApiClient are:
Additionally we still use some of the utility classes like |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Android Lint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/ItemRowAdapterHelper.kt
Fixed
Show fixed
Hide fixed
| ItemFields.CHILD_COUNT, | ||
| ), | ||
| ) | ||
| rows.add(BrowseRowDef(genre.name, itemsRequest, 40)) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| parentId = mFolder.id, | ||
| includeItemTypes = setOf(BaseItemKind.MOVIE), | ||
| ) | ||
| mRows.add(BrowseRowDef(getString(R.string.lbl_movies), movies, 100)) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| parentId = mFolder.id, | ||
| includeItemTypes = setOf(BaseItemKind.SERIES), | ||
| ) | ||
| mRows.add(BrowseRowDef(getString(R.string.lbl_tv_series), series, 100)) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| parentId = mFolder.id, | ||
| excludeItemTypes = setOf(BaseItemKind.MOVIE, BaseItemKind.SERIES), | ||
| ) | ||
| mRows.add(BrowseRowDef(getString(R.string.lbl_other), others, 100)) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| else -> getString(R.string.lbl_by_name) | ||
| } | ||
|
|
||
| mRows.add(BrowseRowDef(header, byName, 100)) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| ), | ||
| ) | ||
|
|
||
| rows.add(BrowseRowDef("#", numbersItemsRequest, 40)) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| ), | ||
| ) | ||
|
|
||
| rows.add(BrowseRowDef(letter.toString(), letterItemsRequest, 40)) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
There are probably some bugs in this one...
Changes
Behavior of the "New premieres" row is slightly changed to make it more efficient and consume less API resources. It still does some client side filtering that can be removed once Jellyfin 10.10 is released (requires jellyfin/jellyfin#12027).
Issues