Send QueueEntry to playback backend #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
playback
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nielsvanvelzen
force-pushed
the
playback-entry-in-backend
branch
from
411006c
to
5d7e2db
Compare
| backendService = backendService, | ||
| ) | ||
|
|
||
| init { | ||
| services.forEach { it.initialize(this, state, Job(job)) } | ||
|
|
||
| // FIXME: This should be more integrated in the future |
Check warning
Code scanning / detekt
Flags a forbidden comment. Warning
crobibero
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Recently I changed the way we work with data in the playback code to use elements. As a result we can now more easily pass the complete queue entry everywhere and read the data we want from it. So the big state classes will slowly empty out.
With this PR the media stream state is no longer a thing. Instead you can just read the media stream from the queue entry. The player backend now receives an entry to allow full access. This is required for my next PR that adds audio normalization support.
I'm still working on some more changes to the media stream resolving, so I've left the existing implementation without much changes. It will need to be changed quite a bit to allow track switching for video playback (selecting subtitles or audio tracks).
Issues
Part of #1057