Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move media session implementation to exoplayer module #3670

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Move media session implementation to exoplayer module #3670

merged 2 commits into from
Jun 12, 2024

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Move media sessions to the exoplayer module, this makes more sense as the implementation uses the media3 library just like exoplayer
    • Will likely rename this module to media3 in the future
  • Drop ui module, it's empty and UI will most be a part of the app itself instead of the playback code

Issues

#1057

@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Jun 12, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jun 12, 2024
@nielsvanvelzen nielsvanvelzen merged commit 2b5f72e into jellyfin:master Jun 12, 2024
6 checks passed
@nielsvanvelzen nielsvanvelzen deleted the playback-media3 branch August 3, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero