Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blur to backdrop images #3674

Merged
merged 14 commits into from
Jun 16, 2024

Conversation

haydenzeller
Copy link
Contributor

@haydenzeller haydenzeller commented Jun 13, 2024

Changes

Add a checkbox in the Theme customization view to blur the backdrop images. Add blurBackdropEnable to UserPreferences. Add _blur to BackgroundService. Add conditional modifier in AppBackground Image() to blur using androidx.compose.ui.draw.blur.

Issues

fix #3642

@haydenzeller haydenzeller changed the title Blur backdrop - Preliminary implementation Add a preference to blur backdrop images Jun 13, 2024
@nielsvanvelzen
Copy link
Member

I don't mind adding a blur to the background, that most likely improves the design. But adding an option for it is entirely unnecessary.

@haydenzeller
Copy link
Contributor Author

Yes I agree, another menu item is rather cumbersome. I was just unsure if you wanted this feature by default or by user pref so I added it just in case. I will update my branch.

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the invalid formatting that needs to be fixed I found one issue, the server splash screen when authenticating should not be blurred.

haydenzeller and others added 2 commits June 15, 2024 08:15
…ground.kt

Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@nielsvanvelzen nielsvanvelzen changed the title Add a preference to blur backdrop images Add a blur to backdrop images Jun 16, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jun 16, 2024
@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Jun 16, 2024
@nielsvanvelzen nielsvanvelzen enabled auto-merge (squash) June 16, 2024 08:41
@nielsvanvelzen nielsvanvelzen merged commit ddc9a01 into jellyfin:master Jun 16, 2024
4 checks passed
@haydenzeller haydenzeller deleted the blur-backdrop branch June 17, 2024 16:54
@acordtag
Copy link

acordtag commented Aug 15, 2024

Hello, where does the 'enable' option appear within the Android TV interface? - cannot be seen on the 'Customization' section; it only appears the "Show backdrops" option.

Currently running Server 10.9.9 and AndroidTV Jellyfin 0.17.3

@nielsvanvelzen
Copy link
Member

Background blur is always enabled on supported devices (Android 12 and newer).

@Antonio1637
Copy link

Hello. Is it possible to disable this features. I have a headache while reading text and scrolling. Blur effect is across whole screen and it does not like nice.

@nielsvanvelzen
Copy link
Member

Please open an issue for that. If there's enough demand we may add an option for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable blurred backdrop
4 participants