Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink BaseItemInfoRowRuntime size #3724

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Shrink BaseItemInfoRowRuntime size #3724

merged 1 commit into from
Jul 6, 2024

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Jul 5, 2024 •
edited
Loading

We've added quite some stuff to the BaseItemInfoRow over time. With 0.17 there's now enough to have it overflow in some scenarios. Let's shrink it down!

Changes

  • Remove "ends at" in BaseItemInfoRow
    • Note that it still shows this information in the FullScreenDetails & player
  • Shorten duration format
  • Add clock icon to duration

9270000381

Issues

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Jul 5, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Jul 5, 2024
@nielsvanvelzen nielsvanvelzen mentioned this pull request Jul 5, 2024
Closed
@nielsvanvelzen nielsvanvelzen merged commit 19bfaa6 into jellyfin:master Jul 6, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the basiteminforow-shorten branch July 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsvanvelzen @thornbill @crobibero