Mark Google Chromecast HD as non-4k capable #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly an upstream bug is preventing this from working, as the chromecast is being idenitified correctly in debugging.
Added a note for the reason of the change.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nielsvanvelzen
added
bug
Make changes suggested by maintainer. Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com>
nielsvanvelzen
requested changes
Aug 4, 2024
Removed unneeded isChromecastHD
nielsvanvelzen
changed the title
nielsvanvelzen
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Add identification for Google Chromecast HD Possibly an upstream bug is preventing this from working, as the chromecast is being idenitified correctly in debugging. * Update DeviceUtils.kt Added a note for the reason of the change. * Removed unintentional imports * Update app/src/main/java/org/jellyfin/androidtv/util/DeviceUtils.kt Make changes suggested by maintainer. Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com> * Update DeviceUtils.kt Removed unneeded isChromecastHD --------- Co-authored-by: Niels van Velzen <nielsvanvelzen@users.noreply.github.com> (cherry picked from commit a8c9f05)
nielsvanvelzen
removed
the
backportable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the Google Chromecast HD to the list of devices unable to support 4K, as it reports it is capable of downscaling but is incapable of doing so in realtime. Change has been discussed with Niels in the discord.
Note
There still may be a bug on the jellyfin server, as the tv app is telling it to send a maximum of 1920x1080 (verified via tcpdump TCPDump Data) but it is still streaming 4k.