Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve behavior when no playable items found #3915

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

nielsvanvelzen
Copy link
Member

In some cases the getItemsToPlay function won't find any items to play. This PR tries to improve this slightly.

Changes

  • Don't attempt to open video player when there are no playable items
  • Try to fallback to the input item when there are no playable items

Issues

Should fix #3910

@nielsvanvelzen nielsvanvelzen added the backportable Change may be backported to a point release (remove label once cherrypicked) label Aug 20, 2024
@nielsvanvelzen nielsvanvelzen merged commit 1f789ac into jellyfin:master Aug 20, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the nothing-to-play branch August 20, 2024 14:44
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.18.0, v0.17.4 Aug 22, 2024
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullpointer Exception when playing a media file via merge-versions plugin and selecting another file first
2 participants