Restore forced aspect ratio for poster types on video items #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
bug
|
Yeah, this will break it again |
crobibero
approved these changes
Oct 11, 2024
|
Unfortunately we'll have to choose our poison and I rather have special show as poster instead of all items without a primary (poster) image using the wrong size, which breaks the browsing grids. I tried adding a special case just for specials but the part of the code that shows the UI unfortunately doesn't have any way of knowing if the item is a special. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue where the image of season 1 of Pioneer One on our demo server wouldn't show properly while trying to reproduce #4062, not sure if it fixes that issue too though. The image logic is a mess.
Changes
Issues
Maybe fixes #4062
Reverts a part of #4015 (@Bond-009 hopefully this doesn't break you images again)