Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close player with invalid state in onCreate #4138

Merged

Conversation

nielsvanvelzen
Copy link
Member

When you shut down your device with the video player open, then start it up again. The OS will resume the app. When this happens the app state is also reset so we don't have anything to play. Closing the player is the way to go! You can't however create a fragment transaction during a fragment transaction, this is what happened because the fragment is being initialized when oCcreate is called. Delay the closing a bit to avoid crashing.

Changes

  • Move player closing when there are no items to the onViewCreated method instead of invoking it in onCreate

Issues

Fixes #4099

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@nielsvanvelzen nielsvanvelzen added bug Something isn't working backportable Change may be backported to a point release (remove label once cherrypicked) labels Nov 1, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Nov 1, 2024
@nielsvanvelzen nielsvanvelzen merged commit bc4f246 into jellyfin:master Nov 2, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the fix-player-resume-crash branch November 2, 2024 09:35
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.18.0, v0.17.9 Nov 2, 2024
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on 0.17.8
2 participants