Catch errors when reporting playback state #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
Nov 5, 2024
| api.playStateApi.reportPlaybackProgress(info) | ||
| runCatching { | ||
| api.playStateApi.reportPlaybackProgress(info) | ||
| }.onFailure { error -> Timber.w(error, "Failed to report playback progress") } |
There was a problem hiding this comment.
This one isn't as excited as the others
There was a problem hiding this comment.
Correct, if the start/stop fails it can screw with activity / playback reporting etc. A missed progress update can be easily recovered with the next update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally the stop event should notify the user too but that can be done later ©️
Changes
Issues