refactor changeStream nested promise chain #58
Conversation
|
Awesome! If it is one thing this client needs it's definitely refactoring. Will take a look ASAP. |
|
Great, thanks! I noticed #59 working towards some similar improvements - I'd be happy to help out with an effort to convert to some of those newer constructs ( Is there documentation on how best to test this codebase locally? |
Please do, that would be very much appreciated! :)
There isn't currently a good way to test without a cast device unfortunately. I've looked into it a little bit and there seems to be ways to emulate a device with this and test that way, but I haven't had the time to look into it further. |
|
I'd like to help test this as well. I'm anxious to have a better chrommecast client, but I'm not sure how (or where) to apply any updates. |
I think maincontroller.js is in need of Queueing support for the web receiver and then Cast Connect receiver support for the Android TV repo in preparation for the new devices due out. The Android 2.0.0 repo is in need of a new Android sender, as I believe it is currently missing. If jellyfin-web's Google Cast ever gets separated away, I'm sure the Chrome sender would benefit from a one-over. |
There was a problem hiding this comment.
Sorry for the delay, #60 blocked me when I got the time to test. Works perfectly from my testing, thanks for the PR :)
Refactored the
changeStreamfunction to clean up a nested promise chain and make it more readable.No logic changes have occurred here - the internal function has been made
asyncin order to handle the promises in a more linear fashion and avoid thenew Promise/resolve()pattern and still maintain order of operations