JellyfinApi static class for server information #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawken93
force-pushed
the
jellyfinapi
branch
from
5ed4809 to
4c815e0
Compare
|
Also reenabled eslint for the files and fixed linting errors. |
hawken93
commented
Dec 12, 2020
hawken93
commented
Dec 12, 2020
| @@ -184,15 +179,10 @@ mgr.addEventListener(cast.framework.events.EventType.ENDED, function () { | |||
| reportPlaybackStopped($scope, getReportingParams($scope)); | |||
| init(); | |||
|
|
|||
| if (!playNextItem()) { | |||
| if (!playbackMgr.playNextItem()) { | |||
There was a problem hiding this comment.
This got caught by the linter, playNextItem was not defined, so this would break playing the next item in the queue I think.
hawken93
commented
Dec 12, 2020
| if ($scope.userId != null) { | ||
| reportEvent('volumechange', true); | ||
| } | ||
| reportEvent('volumechange', true); |
There was a problem hiding this comment.
I guess we could do if (JellyfinApi.userId) - but I removed so many "do we have a connection" checks. I'm assuming someone would connect before these calls would happen.
Assuming clearing server info on disconnect:
If you disconnect from the cast, it may be phone going battery-saving. you may still want the chromecast to keep playing.
Usually the chromecast app is shut down after use, and then all this information will be gone.
hawken93
commented
Dec 12, 2020
hawken93
force-pushed
the
jellyfinapi
branch
from
21b6d7b to
c25814e
Compare
YouKnowBlom
suggested changes
Dec 12, 2020
YouKnowBlom
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All ajax calls and url constructors have been refactored to be handled by JellyfinApi