Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of used driver via ENV variable #101

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

Shadowghost
Copy link
Contributor

@Shadowghost Shadowghost commented Mar 2, 2022

Currently our shipped vainfo or any other program using our ffmpeg can't explicitly set the used driver via the ENV var. I don't see a reason why we should explicitly prevent this, so I added it back.

To explicitly set this environment for Jellyfin only (e.g. multiple GPUs, one for transcoding one for something else) the variable was renamed from LIBVA_DRIVER_NAME to LIBVA_DRIVER_NAME_JELLYFIN.

@nyanmisaka
Copy link
Member

nyanmisaka commented Mar 2, 2022

On a Nvidia prime laptop with both nvidia_dri_video and iHD_dri_video driver installed, if user set LIBVA_DRIVER_NAME=nvidia explicitly to global system to enable hw decoding in firefox/chrome, then the jellyfin-ffmpeg cannot initialize iHD driver for the integrated iGPU/APU to transcoding.

You can rename it to something like LIBVA_DRIVER_NAME_JELLYFIN.

@Shadowghost
Copy link
Contributor Author

Sounds like a reasonable approach for this kind of situations to me. I changed the code in regards to this.

@crobibero crobibero merged commit 4107b39 into jellyfin:jellyfin Mar 4, 2022
@Shadowghost Shadowghost deleted the libva-env-fix branch March 6, 2022 16:46
pdulvp referenced this pull request in pdulvp/jellyfin-qnap Mar 8, 2022
Signed-off-by: pdulvp <pdulvp@laposte.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants