Another try to fix CI #109
Conversation
Shadowghost
commented
Mar 6, 2022
Shadowghost
commented
- properly generate checksums only for existing files
- only upload relevant files to release
…load relevant files to release
| @@ -92,7 +92,7 @@ jobs: | |||
| - name: Prepare Release Assets | |||
| run: |- | |||
| pushd artifact | |||
| for file in *.deb *.zip; do | |||
| find * -type f \( -name "*.deb" -o -name "*.zip" \) | while read file; do | |||
There was a problem hiding this comment.
While I would hate whoever made uppercase bits in these file extensions, it may be worth using -iname for case insensitive filename matching.
There is also a difference between find * and find ., dotfiles are not matched by *.
Not that we'd ever want dotfiles as actual artifacts tho, just pointing it out.
| find * -type f \( -name "*.deb" -o -name "*.zip" \) | while read file; do | |
| find * -type f \( -iname "*.deb" -or -iname "*.zip" \) | while read file; do |
I prefer the long version of or, as it's more clear on what it does without being familiar with find (but it isn't POSIX, which shouldn't matter as we're running this under Ubuntu).
There was a problem hiding this comment.
I agree on using iname but the use of * is intentional to strip the leading ./ from the result of find.
| ./artifact/*.zip' | ||
| ./artifact/*.deb' | ||
| ./artifact/*.sha256sum' |
There was a problem hiding this comment.
Copypasta?
| ./artifact/*.zip' | |
| ./artifact/*.deb' | |
| ./artifact/*.sha256sum' | |
| ./artifact/*.zip | |
| ./artifact/*.deb | |
| ./artifact/*.sha256sum |
Depending on how the glob works here, it may not pick up files in sub-directories.
I'm not sure if that ever matters here.
There was a problem hiding this comment.
Bad copypasta and originally it was intentional to only grab on one level but I guess it doesn't hurt picking up recursivly.
Fixes didn't work anyway so I'll change it in the next try...
