feat: add macOS builder script for CI #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github’s macOS runner will have libxcb installed and that confuses ffmpeg which will add -lX11 to our build, but we are not using any of the x11 features.
nyanmisaka
reviewed
Mar 6, 2024
nyanmisaka
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
LGTM. Still need to wait for @Shadowghost to take a closer look at the changes in GH actions.
Shadowghost
reviewed
Mar 6, 2024
Shadowghost
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Preliminary scripts for macOS builder. There are enough difference that made me to make a dedicated script.
One thing to note is that the arm64 host is macOS 14 exclusive, which means the binary built for arm64 will use newer toolchain than the x86 one using macOS 12 toolchain.
The script currently is only good for CI clean build, but documented the caveats in case someone want to build locally.
Issues
Fixes #339