Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to work with new repository layout #353

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Conversation

joshuaboniface
Copy link
Member

@joshuaboniface joshuaboniface commented Mar 9, 2024

Changes

  1. Use new path layout.
  2. Add major version calculation for use in path.
  3. Remove sha256sums.
  4. Drop non-LTS Ubuntus from builds (matches main server builds)

Issues
N/A

@nyanmisaka
Copy link
Member

There are two more leftovers:

{distro: 'ubuntu', codename: 'lunar'},
{distro: 'ubuntu', codename: 'mantic'}

@nyanmisaka
Copy link
Member

The jellyfin-5.1 branch may also need to do the same thing, and we will need to maintain it for a while for backward compatibility reasons.

Copy link
Contributor

@Shadowghost Shadowghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work as intended.

@joshuaboniface
Copy link
Member Author

joshuaboniface commented Mar 9, 2024

Done and done.

I see the MacOS build is failing, but I'm not sure if that's expected or not. Otherwise, hopefully all good!

@nyanmisaka
Copy link
Member

@joshuaboniface FYI we will defer adding the noble(ubu2404) build target because upstream Debian is transitioning to glib2.0, which results in some dev libs being unavailable in the non-proposed repo. Hopefully they will be available around the time ubu2404 is released.

@joshuaboniface
Copy link
Member Author

Sounds good @nyanmisaka yea I avoided adding it yet for the server CI too because the .NET repo isn't available for it yet :D

1. Use new path layout.
2. Add major version calculation for use in path.
3. Remove sha256sums.
1. Ensure the upload happens to the /srv/incoming directory where the
REPO_USER has permission to write.
2. Use "sudo" to move things into place as everything in the repo is
root-owned.
The burnett01/rsync-deployments action doesn't create parent
directories, which adds the requirement for an additional step to create
the target directory, which I find messy.

Switch to using appleboy/scp-action instead, which does create the
parent directories as expected.
I don't know if this really affects anything, but ensures consistency
with jellyfin-packaging actions
@nyanmisaka nyanmisaka merged commit b05e42d into jellyfin Mar 12, 2024
25 checks passed
@nyanmisaka nyanmisaka deleted the ci-update branch March 12, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants