avfilter/colorspace: fix dovi peak calculation #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max PQ to max mastering display luminance calculation is wrong and not within the scale of ffmpeg. This will overflow the pixels during tone mapping unless the user supplies a peak value to overwrite this. - No need to multiply by reference white for PQ to luminance - The ffmpeg brightness scale for SMPTE ST.2084 is 100 not 10000 Before: 811943.437500 After: 399.9721366995 (4000 nit master display)
Shadowghost
approved these changes
Jun 24, 2024
|
ubuntu noble fails again, not related to this particular PR |
Bond-009
approved these changes
Jun 24, 2024
nyanmisaka
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max PQ to max mastering display luminance calculation is wrong and not within the scale of ffmpeg. This will overflow the pixels during tone mapping unless the user supplies a peak value to overwrite this.
Before: 811943.437500
After: 399.9721366995 (4000 nit master display)
Changes
Issues