Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip the HDR metadata from tonemapx output #444

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Strip the HDR metadata from tonemapx output #444

merged 1 commit into from
Aug 27, 2024

Conversation

nyanmisaka
Copy link
Member

Changes

  • Strip the HDR metadata from tonemapx output

Issues

  • The tonemapx filter currently only produces SDR output, so HDR metadata will cause problems with the libx264 encoder in FFmpeg 7.0+ due to an upstream commit FFmpeg/FFmpeg@471c0a3
[tonemapx @ 00000169f41dd200] Using CPU capabilities: AVX2 FMA3
[libx264 @ 00000169db439e40] content light levels out of range [0,65535]
[vost#0:0/libx264 @ 00000169d2e48b80] Error while opening encoder - maybe incorrect parameters such as bit_rate, rate, width or height.

@nyanmisaka
Strip the HDR metadata from tonemapx output
8083c72 
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
@nyanmisaka nyanmisaka requested a review from a team August 27, 2024 16:26
@gnattu gnattu merged commit efe5f43 into jellyfin:jellyfin-7.0 Aug 27, 2024
26 checks passed
@nyanmisaka nyanmisaka deleted the strip-hdr-meta branch August 27, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bond-009 Bond-009 Bond-009 approved these changes

@gnattu gnattu gnattu approved these changes

@Shadowghost Shadowghost Shadowghost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nyanmisaka @Shadowghost @gnattu @Bond-009