hevc: add 12bit videotoolbox decoding support #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanmisaka
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Interestingly, the three vendors use different pixel memory layouts for yuv444p12.
AV_PIX_FMT_XV36 <- Intel
AV_PIX_FMT_P416 <- Apple
AV_PIX_FMT_YUV444P16 <- NVIDIA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
12bit HEVC works with minimal changes if we process all filters using downsampled
yuv420p10. However, it's important to note that Intel Macs never had hardware support for 12-bit processing, so they will always fall back on software decoding. Even on M1 series, hardware acceleration for 12-bit is incomplete and likely uses hybrid decoding. This is evident by the higher CPU usage compared to 10-bit 4:4:4 inputs, though the M1 still achieves better framerates with lower CPU usage than FFmpeg's native software decoder when decoding 4K HDR 12-bit 4:4:4 inputs.Issues