avcodec/videotoolbox: backport AV1 hardware acceleration #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowghost
approved these changes
Nov 15, 2024
It is normal as those are not supported by current gen hardware from all vendors. |
|
Dav1d is already highly optimized on ARM via NEON (+some SVE(2)), not sure why Apple only provides AVIF support via it. |
nyanmisaka
approved these changes
Nov 15, 2024
Bond-009
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This backports AV1 hardware acceleration from upstream and has been tested on the M4 Max. It is important to note that unlike other hardware acceleration provided by VideoToolbox, Apple does not offer any software fallback for AV1. Consequently, the decode will silently fail for all frames when the system lacks AV1 support or when the video utilizes parameters not supported by the decoder (e.g., 4:2:2 and 4:4:4 color). To address this issue, we must implement a server-side workaround to provide graceful software fallback. This is feasible as Apple has a finite set of chips that do not support AV1, while all current chips support AV1 and possess the same decoding capabilities.
Issues