Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Debian Stretch #80

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Remove Debian Stretch #80

merged 1 commit into from
Jan 3, 2022

Conversation

crobibero
Copy link
Member

Removes "oldoldstable"

@@ -1,6 +1,6 @@
#!/usr/bin/make
DISTRO=stretch
GCC_VER=6
DISTRO=bullseye
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick pass in phone, so not fully aware of all the casuistics

I think changing this doesn't matter? Below the dockerfiles used for compilation are established the correct target and GCC version. Why not use those there as well?
Any idea why this file exists in the first place?
If this is needed, maybe setting it to a default value we don't have to constantly update (like stable, so we don't tie it up to any specific release) it's a better idea?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a default that's set in case the make command is run without args (make -f Dockerfile.make DISTRO=${release} GCC_VER=${gcc_version} ARCH=${arch} in build); changing them shouldn't have any negative effects.

@joshuaboniface joshuaboniface merged commit 5157a35 into jellyfin Jan 3, 2022
@joshuaboniface joshuaboniface deleted the bye-stretch branch January 3, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants