-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework CI #96
Rework CI #96
Conversation
78f6090
to
ad9308d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, but a few comments
05ebe48
to
d2d96d4
Compare
.github/workflows/publish.yaml
Outdated
sudo find /srv/repository/releases/server/${matrix.distro}/ -type l -name "jellyfin-ffmpeg_*" -exec rm {} \; | ||
reprepro -b /srv/repository/${matrix.distro} deleteunreferenced | ||
reprepro -b /srv/repository/${matrix.distro} export | ||
find "/srv/repository/${matrix.distro}" -name "*.deb" | while read file; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a similar consruct to the find above, to ensure it's looking in the right place, or even more specific right down into the exact folder where the upload puts the files.
I'd actually much prefer this upload into a temporary location (i.e. /srv/repository/incoming/ffmpeg
) then import those into reprepro
, then finally move them to the final place and update symlinks. It seems safer that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got it right this time. Sorry for the force push, I fucked up some things locally...
a40d2d3
to
bad47d6
Compare
bad47d6
to
82ff3c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Goals of this PR: