Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework CI #96

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Rework CI #96

merged 2 commits into from
Mar 1, 2022

Conversation

Shadowghost
Copy link
Contributor

Goals of this PR:

  • automatically build all packages with a unified meta workflow
  • append all artifacts to a github release
  • automatically upload releases to the repo server and sync the mirrors

@Shadowghost Shadowghost force-pushed the ci-rework branch 5 times, most recently from 78f6090 to ad9308d Compare February 28, 2022 18:37
Copy link
Contributor

@h1dden-da3m0n h1dden-da3m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but a few comments

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/_meta.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
.github/workflows/_meta.yaml Outdated Show resolved Hide resolved
.github/workflows/publish.yaml Show resolved Hide resolved
sudo find /srv/repository/releases/server/${matrix.distro}/ -type l -name "jellyfin-ffmpeg_*" -exec rm {} \;
reprepro -b /srv/repository/${matrix.distro} deleteunreferenced
reprepro -b /srv/repository/${matrix.distro} export
find "/srv/repository/${matrix.distro}" -name "*.deb" | while read file; do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a similar consruct to the find above, to ensure it's looking in the right place, or even more specific right down into the exact folder where the upload puts the files.

I'd actually much prefer this upload into a temporary location (i.e. /srv/repository/incoming/ffmpeg) then import those into reprepro, then finally move them to the final place and update symlinks. It seems safer that way.

Copy link
Contributor Author

@Shadowghost Shadowghost Feb 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got it right this time. Sorry for the force push, I fucked up some things locally...

@Shadowghost Shadowghost force-pushed the ci-rework branch 3 times, most recently from a40d2d3 to bad47d6 Compare February 28, 2022 23:37
Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@joshuaboniface joshuaboniface merged commit 746cdc1 into jellyfin:jellyfin Mar 1, 2022
@Shadowghost Shadowghost deleted the ci-rework branch March 1, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants