Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPV built-in keyboard shortcut "del" is not working #326

Closed
petoncle opened this issue Mar 5, 2023 · 2 comments
Closed

MPV built-in keyboard shortcut "del" is not working #326

petoncle opened this issue Mar 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@petoncle
Copy link

petoncle commented Mar 5, 2023

"del" is a default MPV keyboard shortcut that allows the user to cycle OSC visibility.

It does not do anything when I hit the "del" key in Jellyfin MPV Shim (it does work in vanilla MPV). The logs do not seem to contain any relevant information (nothing related to shortcuts; when hitting "del", no new statement is being logged).

Windows 10
Jellyfin MPV Shim 2.5.0

If this keyboard shortcut is expected not to work in Jellyfin MPV Shim, is there any reason why?

@petoncle petoncle added the bug Something isn't working label Mar 5, 2023
@iwalton3
Copy link
Member

iwalton3 commented Mar 5, 2023

This is probably related to using a custom OSC by default now. I should be able to provide a replacement for it.

iwalton3 added a commit that referenced this issue Mar 6, 2023
@iwalton3
Copy link
Member

iwalton3 commented Mar 6, 2023

This will be fixed in the next release.

@iwalton3 iwalton3 closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants