Add Tvdb Collection Ids #162
Conversation
scampower3
added
the
feature
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (isOfficial is true) | ||
| { | ||
| var id = jsonElementCollection.GetProperty("id").GetInt32().ToString(CultureInfo.InvariantCulture); | ||
| collectionIds += id + ";"; |
Check notice
Code scanning / CodeQL
String concatenation in loop Note
| foreach (var collection in collections) | ||
| { | ||
| if (collection is JsonElement jsonElementCollection) | ||
| { | ||
| var isOfficial = jsonElementCollection.GetProperty("isOfficial").GetBoolean(); | ||
| if (isOfficial is true) | ||
| { | ||
| var id = jsonElementCollection.GetProperty("id").GetInt32().ToString(CultureInfo.InvariantCulture); | ||
| collectionIds += id + ";"; | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where Note
| .Where(x => x.GetProperty("isOfficial").GetBoolean()) | ||
| .Select(x => x.GetProperty("id").GetInt32().ToString(CultureInfo.InvariantCulture)) |
There was a problem hiding this comment.
This looks super clean but this would throw an exception if a property is missing or not a bool/int
Can't rely on tvdb to be consistent 🙃
There was a problem hiding this comment.
As far as I can tell, these two property is always present.
I can wrap a try catch around this.
| catch (Exception e) | ||
| { | ||
| _logger.LogError(e, "Failed to retrieve collection for series {TvdbId}:{SeriesName}", tvdbSeries.Id, tvdbSeries.Name); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
A series can have multiple tvdb collection ids. So store them as a string and delimit them with semicolons.
For use for future tvdb collection management